feat: make dpselector api jsonld aware #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
+ Coverage 71.36% 71.43% +0.06%
==========================================
Files 806 811 +5
Lines 16401 16502 +101
Branches 951 956 +5
==========================================
+ Hits 11705 11788 +83
- Misses 4301 4315 +14
- Partials 395 399 +4
☔ View full report in Codecov by Sentry. |
paullatzelsperger
added
enhancement
ndr-brt
reviewed
Jul 18, 2023
paullatzelsperger
requested review from
ronjaquensel and
juliapampus
as code owners
paullatzelsperger
force-pushed
the
feat/make_dpselector_api_jsonld_aware
branch
from
c857e65
to
98f5767
Compare
...n/java/org/eclipse/edc/connector/dataplane/selector/api/schemas/DataPlaneInstanceSchema.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/edc/connector/dataplane/selector/api/schemas/SelectionRequestSchema.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Jul 19, 2023
...rc/main/java/org/eclipse/edc/connector/dataplane/selector/api/schemas/DataAddressSchema.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/org/eclipse/edc/connector/dataplane/selector/api/DataplaneSelectorApi.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/edc/connector/dataplane/selector/api/DataplaneSelectorApiController.java
Show resolved
Hide resolved
...n/java/org/eclipse/edc/connector/dataplane/selector/api/schemas/DataPlaneInstanceSchema.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/edc/connector/dataplane/selector/api/schemas/SelectionRequestSchema.java
Outdated
Show resolved
Hide resolved
...e/edc/connector/dataplane/selector/transformer/JsonObjectToDataPlaneInstanceTransformer.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/edc/connector/dataplane/selector/spi/instance/DataPlaneInstance.java
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feat/make_dpselector_api_jsonld_aware
branch
from
7d1ce29
to
0dece1d
Compare
ndr-brt
approved these changes
Jul 19, 2023
ronjaquensel
approved these changes
Jul 19, 2023
paullatzelsperger
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: make DataPlaneSelectorApi JSON-LD aware * added integration test * added extension verification * moved JsonObjectToDataAddressTransformer * fixed remote DP selector client * fixed transformer * fixed integration tests * fixed tests * changed path to /v2/dataplanes * pr remarks * re-used DataAddressSchema from Management API Config * moved JsonObjectToDataAddressTransformer to management api config * renamed selector api package to v2 * fixed tests, build file * generic transformer is registered in the mgmt api config * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR converts the DataPlane Selector API to use JSON-LD.
Why it does that
Consistency with other APIs
Further notes
RemoteDataPlaneSelectorClientTestto use theRestControllerTestBaseEndToEndTransferParticipantwas also updated to use JSON-LDpublicApiUrlis now prefixed withEDC_NAMESPACELinked Issue(s)
Closes #3061
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.